Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency fix for ReDoS vulnerability #79

Merged
merged 1 commit into from May 3, 2022

Conversation

zetlen
Copy link
Collaborator

@zetlen zetlen commented May 3, 2022

VALID_DOMAIN regex had exponential-time vulnerability on certain strings.

Switched from vulnerable VALID_DOMAIN regex to is-valid-domain lib, which uses a known list of TLDs.

@zetlen zetlen merged commit b076321 into master May 3, 2022
@mcalthrop-lego
Copy link

mcalthrop-lego commented May 4, 2022

Hi @zetlen

Could you elaborate on the reason for disallowing subdomains?

This used to work well in our setup, and now does not, as we require certificate generation for subdomains.

From what I can see, this should not affect the ReDoS issue the original PR mitigates.

@NewFuture
Copy link
Contributor

NewFuture commented May 10, 2022

@zetlen @davewasmer it breaks subdomain 😮

@drmcclelland
Copy link

drmcclelland commented May 12, 2022

I think this change also also broke "localhost"...

@mcalthrop-lego
Copy link

mcalthrop-lego commented May 16, 2022

@zetlen Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants