Fix cobertura XML by adding fake signature to methods

davglass · Nov 14, 2012 · 49789fb · 49789fb
1 parent 6f1e7f8
commit 49789fb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -133,6 +133,7 @@ All the features of istanbul can be accessed as a library using its [public API]
 Changelog
 ---------
 
+* v0.1.22 : Add signature attribute to cobertura method tags to fix NPE by the Hudson publisher
 * v0.1.21 : Add cobertura XML report format; exprimental for now
 * v0.1.20 : Fix HTML/ lcov report interface to be more customizable for middleware needs
 * v0.1.19 : make all hooking non-destructive in that already loaded modules are never reloaded.

diff --git a/lib/report/cobertura.js b/lib/report/cobertura.js
@@ -93,6 +93,7 @@ function addClassStats(node, fileCoverage, writer) {
         writer.println('\t\t\t<method' +
             attr('name', name) +
             attr('hits', hits) +
+            attr('signature', '()V') + //fake out a no-args void return
             ' />');
     });
     writer.println('\t\t</methods>');

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "istanbul",
-    "version": "0.1.21",
+    "version": "0.1.22",
     "description": "Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale",
     "keywords": [ "coverage", "code coverage", "JS code coverage", "JS coverage" ],
     "author": "Krishnan Anantheswaran <kananthmail-github@yahoo.com>",