Fix do not use {a} as constructor, and adds test

davglass · Aug 7, 2012 · b197dca · b197dca
1 parent 1764ddb
commit b197dca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/jshint.js b/jshint.js
@@ -3107,7 +3107,7 @@ loop:   for (;;) {
                 case "Boolean":
                 case "Math":
                 case "JSON":
-                    warning("Do not use {a} as a constructor.", token, c.value);
+                    warning("Do not use {a} as a constructor.", prevtoken, c.value);
                     break;
                 case "Function":
                     if (!option.evil) {

diff --git a/tests/unit/core.js b/tests/unit/core.js
@@ -429,3 +429,13 @@ exports.testInvalidSource = function () {
         .addError(0, "Input is an empty array.")
         .test([]);
 };
+
+exports.testConstructor = function () {
+    var code = "new Number(5);";
+
+    TestRun()
+        .addError(1, "Do not use Number as a constructor.", {
+            character: 1
+        })
+        .test(code);
+};