Fix Sarif output relationship target id format. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @david-a-wheeler, can you pls take a look this fix, its required for adding flawfinder Github action (#51), since the sarif with this issue will fail the validation when upload the sarif result to Github Security tab. Flawfinder Github action use pip to install flawfinder, do we need to create a release to let pip to get latest changes? If yes can you please help to create a release? |
|
Thanks! Agreed. Merging. |
|
@david-a-wheeler can you pls also create a new release so that Github action can install the latest version. Thanks! |
|
Ah, the fun of dependencies. I'm thinking I should merge #51 and then release. Any objections? |
|
sure have updated #51 pls take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relationship target id should be string not an integer.