Merge Toys redux #10
Merge Toys redux #10
Conversation
There was a problem hiding this comment.
This looks very good! Just minor things, see my comments.
@jvmancuso Why do we need this gym fork? To me it looks like your fork is the same as the openai master.
We should do the little updates to the render function and change the font as discussed in #8 Then I think we can merge this! (EDIT: changes made in #14)
| @@ -53,7 +53,10 @@ | |||
| "reinforcement learning " | |||
| ), | |||
| install_requires=["gym", "ai-safety-gridworlds", "numpy>=1.14.5"], | |||
| dependency_links=["https://github.com/jvmancuso/ai-safety-gridworlds/tarball/master#egg=ai-safety-gridworlds-1.2.2"], | |||
| dependency_links=[ | |||
| "https://github.com/jvmancuso/gym/tarball/master#egg=gym-0.10.10", | |||
There was a problem hiding this comment.
Why do we use this fork? The PR you mention seems to have been merged into the openai/gym master already.
There was a problem hiding this comment.
The version of gym from PyPI is 0.10.9 and was released 5 Nov, 2018, so any PRs merged to master since then aren't on PyPI. openai/gym#492 was merged after that. It seemed reasonable to point our dependency_link arg to their master branch since the package is now in maintenance mode, but setuptools wasn't able to find it and would fallback to the 0.10.9 version on PyPI.
I can try again to see if that'll work (cause there were other complicating factors at the time that I found later), but what I ended up doing was making a release on my fork and pointing our dependency_link to that.
There was a problem hiding this comment.
Sure, that makes sense. Pointing it to their master branch works for me, see cfcf23b Have a look if it works for you as well 😄
|
Closed by #14 :) |
Closes #7
Builds on #8 to include necessaries for metric tracking in agents repo and to conform to Python conventions.