Replace deprecated load(False) with resolve() #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems unobjectionable, and will get rid of an annoying warning every time an environment is loaded. Can this be merged? @jonasschneider Closes #1219 |
AdamGleave
added a commit
to HumanCompatibleAI/gym
that referenced
this pull request
Nov 22, 2018
|
+1 @pzhokhov It would be nice to merge this fix, because it resolves the annoying warnings for Python 3.7. |
jvmncs
added a commit
to david-lindner/safe-grid-gym
that referenced
this pull request
Jan 11, 2019
|
I have removed the env.load(False) by env.resolve() and it s now working fine. |
|
I've tried this, but it's just get rid of the warning, the gift is still not appeared, but the code runs without errors and warnings. |
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/pypa/setuptools/blob/v38.5.2/pkg_resources/__init__.py#L2423
entry_point.load(False)is deprecated