Sourcery refactored master branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if text.startswith(prefix): | ||
| return text[len(prefix):] | ||
| return text | ||
| return text[len(prefix):] if text.startswith(prefix) else text |
There was a problem hiding this comment.
Function remove_prefix refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-29
to
+27
| vcf = "BEGIN:VCARD" | ||
| vcf += "\n" | ||
| vcf = "BEGIN:VCARD" + "\n" |
There was a problem hiding this comment.
Function vCard_gen refactored with the following changes:
- Replace assignment and augmented assignment with single assignment (
merge-assign-and-aug-assign) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| @@ -90,7 +87,6 @@ def teardown_request(exception): | |||
|
|
|||
|
|
|||
| @app.route('/') | |||
| # @ldap.login_required | |||
There was a problem hiding this comment.
Function index refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Convert for loop into list comprehension (
list-comprehension)
This removes the following comments ( why? ):
# if str(username).casefold() == str(row[9]).casefold():
# @ldap.login_required
# login_id = row[0]
| return render_template('phonebook.html', people=people, login_id=login_id, admin=admin) | ||
|
|
||
|
|
||
| @app.route('/new', endpoint='edit', methods=['GET', 'POST']) | ||
| @app.route('/edit/<id>', methods=['GET', 'POST']) | ||
| # @ldap.login_required |
There was a problem hiding this comment.
Function edit refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
This removes the following comments ( why? ):
# @ldap.login_required
Comment on lines
-197
to
+190
| # @ldap.login_required | ||
| def delete(id): | ||
| username = remove_prefix(session['user_id'], 'MAIN\\') | ||
| if username in admin_users: | ||
| admin = True | ||
| else: | ||
| admin = False | ||
| admin = username in admin_users |
There was a problem hiding this comment.
Function delete refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
This removes the following comments ( why? ):
# @ldap.login_required
Comment on lines
-219
to
+207
| else: | ||
| session['user_id'] = remove_prefix(request.form['user'], conf_domain + '\\') | ||
| return redirect('/') | ||
| session['user_id'] = remove_prefix(request.form['user'], conf_domain + '\\') | ||
| return redirect('/') |
There was a problem hiding this comment.
Function login refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-245
to
+235
| # @ldap.login_required | ||
| def vCard_all(): | ||
| cur = g.db.execute( | ||
| 'SELECT id, position, lastname, firstname, middlename, intphone, cellphone, email, birthday, login FROM persons WHERE active ORDER BY lastname') | ||
| people = [] | ||
| for row in cur.fetchall(): | ||
| people.append({ | ||
| people = [ | ||
| { |
There was a problem hiding this comment.
Function vCard_all refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Use str.join() instead of for loop (
use-join)
This removes the following comments ( why? ):
# @ldap.login_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!