This repository has been archived by the owner on Mar 23, 2022. It is now read-only.
Quick fix to ensure temporary files are not left around after plugin execution #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each run of the plugin, a temporary file is created, but never cleaned. This check ensure that the temporary file is deleted at the JVM exit.
davidB
added a commit
that referenced
this pull request
May 10, 2011
Quick fix to ensure temporary files are not left around after plugin execution
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello David,
I have been using your Maven plugin for a while and it is working very well. Thanks for the good job. I discovered a small issue while using it in that for each execution, a temporary file is created, but never cleaned. Of course those files are created in a temporary folder, but if it is not purged, then a lot of files will stay inside. That's what is happening on my CI infrastructure for example.
Thus, I made this small one-line change to ensure that temporary files are deleted once the JVM is shut down.
Would you mind merging this fix for the next version of your plugin?
Best regards,
Reynald