Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deps and retrofitted to new apis #28

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Jul 27, 2021

Signed-off-by: Matt Wrock matt@mattwrock.com

Signed-off-by: Matt Wrock <matt@mattwrock.com>
Comment on lines +17 to +29
bytes = "*"
futures = "*"
log = "*"
nom = "*"
owning_ref = "*"
pin-project = "*"
rand = "*"
serde = { version = "*", features = ["derive"] }
serde_json = "*"
tokio = { version = "*", features = ["io-util", "macros", "sync", "time", "net"] }
tokio-util = { version = "*", features = ["codec"] }
tokio-stream = { version = "*", features = ["sync"] }
uuid = { version = "*", features = ["v4"] }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Matt, this is awesome! Thanks for the PR.

The one change is I generally think it is bad form to have "*" dependencies in a library. Could you change the dependency sections to

[dependencies]
bytes = "1.0"
futures = "0.3"
log = "0.4"
nom = "6.2"
owning_ref = "0.4"
pin-project = "1.0"
rand = "0.8"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
tokio = { version = "1.9", features = ["io-util", "macros", "sync", "time", "net"] }
tokio-util = { version = "0.6", features = ["codec"] }
tokio-stream = { version = "0.1", features = ["sync"] }
uuid = { version = "0.8", features = ["v4"] }

# Optional dependencies
native-tls-crate = { version = "0.2", optional = true, package = "native-tls" }
rustls = { version = "0.19", optional = true }
tokio-native-tls = { version = "0.3", optional = true }
tokio-rustls = { version = "0.22", optional = true }

[dev-dependencies]
env_logger = "0.9"
hostname = "0.3"
tokio = { version = "1.9", features = ["process", "rt-multi-thread"] }

@davidMcneil davidMcneil merged commit 11834c9 into davidMcneil:master Nov 8, 2021
@davidMcneil davidMcneil mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants