Mostly travis tweaks, plus some small stuff #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
bkeepers
added a commit
to probot/probot
that referenced
this pull request
Feb 18, 2018
bkeepers
added a commit
to probot/probot
that referenced
this pull request
Feb 18, 2018
|
This is causing some breakage in Probot probot/probot#433. I'm investigating if it's something we're doing wrong on our end, but wanted to report it in case it's affecting anyone else. |
|
Thanks, @bkeepers. Let me know what you discover. |
bkeepers
added a commit
to probot/probot
that referenced
this pull request
Feb 28, 2018
bkeepers
added a commit
to probot/probot
that referenced
this pull request
Feb 28, 2018
tigran25
pushed a commit
to tigran25/probot
that referenced
this pull request
Mar 22, 2023
serhivov
pushed a commit
to serhivov/probot
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
David, you'll need to add the Travis info.
Also, using
fn.call(this, ...)will get us slightly higher fidelity monkey patch behavior. I don't think Express ever relies on dynamic context, but just in case.