Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: fn.call is not a function #42

Closed
gr2m opened this issue Feb 18, 2018 · 0 comments · Fixed by #43
Closed

TypeError: fn.call is not a function #42

gr2m opened this issue Feb 18, 2018 · 0 comments · Fixed by #43

Comments

@gr2m
Copy link
Collaborator

gr2m commented Feb 18, 2018

The last deploy broke something™️

  TypeError: fn.call is not a function
      at /home/nowuser/src/node_modules/express-async-errors/index.js:17:20
      at Layer.handle [as handle_request] (/home/nowuser/src/node_modules/express/lib/router/layer.js:95:5)
      at trim_prefix (/home/nowuser/src/node_modules/express/lib/router/index.js:317:13)
      at /home/nowuser/src/node_modules/express/lib/router/index.js:284:7
      at Function.process_params (/home/nowuser/src/node_modules/express/lib/router/index.js:335:12)
      at next (/home/nowuser/src/node_modules/express/lib/router/index.js:275:10)
      at /home/nowuser/src/node_modules/probot/lib/middleware/logging.js:33:5
      at /home/nowuser/src/node_modules/express-async-errors/index.js:17:20
      at Layer.handle [as handle_request] (/home/nowuser/src/node_modules/express/lib/router/layer.js:95:5)
      at trim_prefix (/home/nowuser/src/node_modules/express/lib/router/index.js:317:13)
      at /home/nowuser/src/node_modules/express/lib/router/index.js:284:7
      at Function.process_params (/home/nowuser/src/node_modules/express/lib/router/index.js:335:12)
      at next (/home/nowuser/src/node_modules/express/lib/router/index.js:275:10)
      at expressInit (/home/nowuser/src/node_modules/express/lib/middleware/init.js:40:5)
      at /home/nowuser/src/node_modules/express-async-errors/index.js:17:20
      at Layer.handle [as handle_request] (/home/nowuser/src/node_modules/express/lib/router/layer.js:95:5)
      at trim_prefix (/home/nowuser/src/node_modules/express/lib/router/index.js:317:13)
      at /home/nowuser/src/node_modules/express/lib/router/index.js:284:7
      at Function.process_params (/home/nowuser/src/node_modules/express/lib/router/index.js:335:12)
      at next (/home/nowuser/src/node_modules/express/lib/router/index.js:275:10)
      at query (/home/nowuser/src/node_modules/express/lib/middleware/query.js:45:5)
      at /home/nowuser/src/node_modules/express-async-errors/index.js:17:20
      at Layer.handle [as handle_request] (/home/nowuser/src/node_modules/express/lib/router/layer.js:95:5)
      at trim_prefix (/home/nowuser/src/node_modules/express/lib/router/index.js:317:13)
      at /home/nowuser/src/node_modules/express/lib/router/index.js:284:7
      at Function.process_params (/home/nowuser/src/node_modules/express/lib/router/index.js:335:12)
      at next (/home/nowuser/src/node_modules/express/lib/router/index.js:275:10)
      at Function.handle (/home/nowuser/src/node_modules/express/lib/router/index.js:174:3)
      at Function.handle (/home/nowuser/src/node_modules/express/lib/application.js:174:10)
      at Server.app (/home/nowuser/src/node_modules/express/lib/express.js:39:9)
      at emitTwo (events.js:126:13)
      at Server.emit (events.js:214:7)
      at parserOnIncoming (_http_server.js:602:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)

I'm positive that it was unrelated to the changes. But it looks as if downgrading probot to v4 fixes the problem, I tested it on Glitch. I'll do that for now
gr2m added a commit that referenced this issue Feb 18, 2018
@gr2m
build(package): downgrade probot back to 4.0.0
4d8b0ab 
works around #42, I don’t yet know why
@gr2m gr2m mentioned this issue Feb 18, 2018
Merged
@gr2m gr2m closed this as completed in #43 Feb 18, 2018
gr2m added a commit that referenced this issue Feb 18, 2018
@gr2m
build(package): downgrade probot back to 4.0.0
46a323c 
works around #42, I don’t yet know why
bkeepers added a commit to probot/probot that referenced this issue Feb 18, 2018
@bkeepers
Lock to specific version of express-async-errors
cc74532 
davidbanham/express-async-errors#4 is the cause
for wip/app#42
@bkeepers bkeepers mentioned this issue Feb 18, 2018
Merged
bkeepers added a commit to probot/probot that referenced this issue Feb 18, 2018
@bkeepers
Lock to specific version of express-async-errors (#432)
8c6ea7d 
davidbanham/express-async-errors#4 is the cause
for wip/app#42
@bkeepers bkeepers mentioned this issue Feb 18, 2018
Closed
bkeepers added a commit to probot/probot that referenced this issue Feb 28, 2018
@bkeepers
Lock to specific version of express-async-errors (#432)
689d9b0 
davidbanham/express-async-errors#4 is the cause
for wip/app#42
bkeepers added a commit to probot/probot that referenced this issue Feb 28, 2018
@bkeepers
Lock to specific version of express-async-errors (#432) (#444)
bff87ef 
davidbanham/express-async-errors#4 is the cause
for wip/app#42
tigran25 pushed a commit to tigran25/probot that referenced this issue Mar 22, 2023
@bkeepers
Lock to specific version of express-async-errors (#432) (#444)
6a1b1e1 
davidbanham/express-async-errors#4 is the cause
for wip/app#42
serhivov pushed a commit to serhivov/probot that referenced this issue Mar 22, 2023
@bkeepers
Lock to specific version of express-async-errors (#432) (#444)
68c2788 
davidbanham/express-async-errors#4 is the cause
for wip/app#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Downgrade probot to 4.0.0 wip/app
1 participant
@gr2m