-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gaussian blur support min_ampl #307
Conversation
Hey @jishi92 thanks for the contribution! Could you write unit tests as per the CONTRIBUTING document? Just some simple passing and failing test to check the parameter, perhaps with the golden images? There's plenty of examples in the code. Thank you!! |
Hi @tonimelisma, I create a issue [#309] and write a unit test according to the CONTRIBUTING document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Should really clean up the golden unit tests and get some system to autoupdate the golden images when libvips announces a new version
Co-authored-by: muyouran <muyouran@pinduoduo.com>
* Original image type (davidbyttow#299) * - add golden * - freeCString abstraction * When implicitly converting the image type (BMP to PNG), keep the original format available for query * gaussian blur support min_ampl (davidbyttow#307) Co-authored-by: muyouran <muyouran@pinduoduo.com> * Add APIs to get image EXIF data and ICC profile data (davidbyttow#317) * Add support for high-bit-depth AVIF and HEIF images (davidbyttow#322) * Fix bug with icc transform bit depth (davidbyttow#323) * Determine libvips version runtime (davidbyttow#320) * add ExtractBandToImage (davidbyttow#324) * Update image.go Add function to extract a band into a new image instead of replacing the current image ref * Update image.go * add test Co-authored-by: Roffe <roffe@roffe.nu> * BandSplit() split an n-band image into n separate images (davidbyttow#326) * BandSplit() split an n-band image into n separate images * move tests Co-authored-by: Roffe <roffe@roffe.nu> * Bump CI to latest Ubuntu (davidbyttow#329) * Improved exif extraction (davidbyttow#325) * Add support for reading + writing EXIF data * Fix test for removing exif * Cleanup tests * Fix removes exif test on ubuntu * TIFF may not iptc data * Cleanup test images * add images for ubuntu 22 lts (davidbyttow#328) Co-authored-by: Roffe <roffe@roffe.nu> * don't use deprecated functions Co-authored-by: Qisen <1620671486@qq.com> Co-authored-by: muyouran <muyouran@pinduoduo.com> Co-authored-by: Logan Shire <logan.shire@gmail.com> Co-authored-by: tgmpje <65441725+tgmpje@users.noreply.github.com> Co-authored-by: Joakim Karlsson <5434736+roffe@users.noreply.github.com> Co-authored-by: Roffe <roffe@roffe.nu> Co-authored-by: Toni Melisma <59022391+tonimelisma@users.noreply.github.com>
No description provided.