Fix bug with icc transform bit depth #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonimelisma This one is a pretty straightforward bug fix 😅 |
Elad-Laufer
pushed a commit
to wix-incubator/govips-contrib
that referenced
this pull request
Nov 22, 2022
Elad-Laufer
added a commit
to wix-playground/govips
that referenced
this pull request
Nov 22, 2022
* Original image type (davidbyttow#299) * - add golden * - freeCString abstraction * When implicitly converting the image type (BMP to PNG), keep the original format available for query * gaussian blur support min_ampl (davidbyttow#307) Co-authored-by: muyouran <muyouran@pinduoduo.com> * Add APIs to get image EXIF data and ICC profile data (davidbyttow#317) * Add support for high-bit-depth AVIF and HEIF images (davidbyttow#322) * Fix bug with icc transform bit depth (davidbyttow#323) * Determine libvips version runtime (davidbyttow#320) * add ExtractBandToImage (davidbyttow#324) * Update image.go Add function to extract a band into a new image instead of replacing the current image ref * Update image.go * add test Co-authored-by: Roffe <roffe@roffe.nu> * BandSplit() split an n-band image into n separate images (davidbyttow#326) * BandSplit() split an n-band image into n separate images * move tests Co-authored-by: Roffe <roffe@roffe.nu> * Bump CI to latest Ubuntu (davidbyttow#329) * Improved exif extraction (davidbyttow#325) * Add support for reading + writing EXIF data * Fix test for removing exif * Cleanup tests * Fix removes exif test on ubuntu * TIFF may not iptc data * Cleanup test images * add images for ubuntu 22 lts (davidbyttow#328) Co-authored-by: Roffe <roffe@roffe.nu> * don't use deprecated functions Co-authored-by: Qisen <1620671486@qq.com> Co-authored-by: muyouran <muyouran@pinduoduo.com> Co-authored-by: Logan Shire <logan.shire@gmail.com> Co-authored-by: tgmpje <65441725+tgmpje@users.noreply.github.com> Co-authored-by: Joakim Karlsson <5434736+roffe@users.noreply.github.com> Co-authored-by: Roffe <roffe@roffe.nu> Co-authored-by: Toni Melisma <59022391+tonimelisma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the TransformICCProfile API. Here I was passing 0 for the bit depth (leaving it unset) but the default value if you do this is 8-bit. This causes ICC transforms of >8-bit images to revert to 8-bit and become distorted. The code I'm adding here was copied from the adjacent OptimizeICCProfile method which defaults to 16-bit processing unless the source image was already 8-bit.