[Enhancement] Removes deprecated keyCode & keypress usage in search #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyCode is deprecated in favour of code & key. We use key as we care about the value of the key rather than it's physical position https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode keypress is a deprecated event in favour of keydown which represents the same thing but isn't deprecated https://developer.mozilla.org/en-US/docs/Web/API/Document/keypress_event
|
This is great, thanks @studioromeo! Love that they, and you, changed it to something more semantic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the search page there's usage of some keyboard events that are now deprecated and could be removed from future browsers.
keyCodeis deprecated in favour of code & key. We use key as we care about the value of the key rather than it's physical position. (https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode)keypressis a deprecated event in favour of keydown which represents the same thing but isn't deprecated. (https://developer.mozilla.org/en-US/docs/Web/API/Document/keypress_event)The javascript is pretty much the same as before so this should be ok for people to port into their themes that used this as a boilerplate.