Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialising a token not including all values #584

Open
aakifn opened this issue Dec 29, 2021 · 0 comments
Open

Serialising a token not including all values #584

aakifn opened this issue Dec 29, 2021 · 0 comments

Comments

@aakifn
Copy link

aakifn commented Dec 29, 2021

This change implements a __sleep() method but as a result, anything other than the accessToken is not serialised. This means data such as the token lifetime or any extra params relating to the token are no longer persisted.

The PR it belongs to suggests it was PHP 8 related but I'm not sure why. What was the reasoning for this change?
aakifn added a commit to xenforo-ltd/PHPoAuthLib that referenced this issue Dec 29, 2021
@aakifn
Back this change out for now as serialising only the accessToken brea…
7d307d0 
…ks our usage of this library. More details here: daviddesberg#584
@clintonb clintonb mentioned this issue Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aakifn