Add Advance call to protocol reader #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
commented
Dec 25, 2019
| @@ -87,89 +89,89 @@ public ProtocolReader(ConnectionContext connection, IProtocolReader<TReadMessage | |||
|
|
|||
| public ConnectionContext Connection { get; } | |||
|
|
|||
| public async ValueTask<TReadMessage> ReadAsync(CancellationToken cancellationToken = default) | |||
| public async ValueTask<ReadResult<TReadMessage>> ReadAsync(CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
- Nested structs aren't great but there's nothing we can do about that.
- Should this return the previously read value if Advance isn't called?
MithrilMan
reviewed
Dec 25, 2019
|
|
||
| public readonly struct ReadResult<TMessage> | ||
| { | ||
| public ReadResult(TMessage message, bool isCanceled, bool isCompleted) |
There was a problem hiding this comment.
doesn't this causes TMessage message (that's a struct in the example) being copied into ReadResult?
should this be a ref?
There was a problem hiding this comment.
It does. I'm not sure the struct can be readonly and return a ref to the TMessage
Repository owner
deleted a comment from
davidfowl
Dec 25, 2019
JanEggers
reviewed
Dec 25, 2019
There was a problem hiding this comment.
im okay with the api change in general. but when applying this to my mqtt playground i found an error.
in case TryParseMessage fails because the message is incomplete the next call to readasync throws because you did not call advance and the pipe thinks there is a read operation in progress.
|
@JanEggers might be time to add tests 😄 |
- Added some basic tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IProtocolReader<TMessage>to avoid copying incomingbyte[]directly, we add anAdvance()method to the reader to allow the caller to decide when memory is recycled.ReadResult<TMessage>to propagate cancellation and completion information.cc @JanEggers