Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processor configuration validation #4

Closed
davidfrigola opened this issue Nov 25, 2013 · 3 comments
Closed

Processor configuration validation #4

davidfrigola opened this issue Nov 25, 2013 · 3 comments
Assignees
@davidfrigola
Labels
development enhancement
Milestone
0.3

Comments

@davidfrigola
Copy link
Owner

Create a Validator abstract class and implementations for each processor.
Default validator should be used when none provided ( defaul parameter value in constructor init(self,config, validator=ProcessorDefaultValidatorImplementation??) if such a thing exist, or something programatically driven
@ghost ghost assigned davidfrigola Nov 25, 2013
davidfrigola added a commit that referenced this issue Nov 25, 2013
@davidfrigola
#4 First version torrent client (no tests)
4c52d22
@davidfrigola
Copy link
Owner Author

Moved to Milestone 0.2

davidfrigola added a commit that referenced this issue Feb 4, 2014
@davidfrigola
#4 Configuration validators skeleton
25d37cd
davidfrigola added a commit that referenced this issue Feb 8, 2014
@davidfrigola
#4 Sample
03531da
@davidfrigola
Copy link
Owner Author

This has been moved to Milestone 0.3

init method in base processors class (AbstractProcessor) will call a validateConfig method that should be overriden by child processor classes.

davidfrigola added a commit that referenced this issue Feb 9, 2014
@davidfrigola
#4 Configuration validators
c5295e5 
Added multiple (list of) validator
Added samples
Added tests

Modified HtmlProcessor to use the new validators approach
davidfrigola added a commit that referenced this issue Feb 9, 2014
@davidfrigola
#4 Instance type check for the configuration
d5f00dd 
Added validator that checks key in the config dict is a concrete type
Added tests
@davidfrigola davidfrigola mentioned this issue Feb 9, 2014
Open
@davidfrigola
Copy link
Owner Author

Done base implementation.
Some tests and samples, but no refactor for all existing processors.
Will do in a new issue (#45 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfrigola davidfrigola

Labels
development enhancement
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@davidfrigola