Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce usage of Greaseweazle firmware v0.24 after adapting CMD_READ_… #221

Merged
merged 1 commit into from
May 23, 2021

Conversation

hpingel
Copy link

@hpingel hpingel commented Jan 21, 2021

…FLUX and CMD_WRITE_FLUX

@davidgiven
Copy link
Owner

Sorry about the delay --- been working on other things...

Thanks very much for this! However I would rather like to keep compatibility with v23 as well as v24, as given that I'm a third-party client I don't really want to demand that people upgrade their Greaseweazle firmware. Any chance of selecting the appropriate API based on the reported version? It should be a simple matter of stashing the version number in a global variable in a member variable and then using one or the other based on the value.

@hpingel
Copy link
Author

hpingel commented Feb 19, 2021

Thanks. Yeah, I will look into a flexible approach to allow v0.22+. May take some time!

@davidgiven davidgiven merged commit 7a885e2 into davidgiven:master May 23, 2021
@davidgiven
Copy link
Owner

I've actually overhauled all the USB stuff (and, sadly, had to take out the GreaseWeazle autodetection because I can't make it work on Windows), and merged your code along with it. Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants