Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to python 3 #27

Merged
merged 6 commits into from
Apr 5, 2018
Merged

switch to python 3 #27

merged 6 commits into from
Apr 5, 2018

Conversation

scoutsaachi
Copy link
Collaborator

Switch TICC solver to python 3

The mammoth changes in TICC_helper are just converting all the indentation to spaces instead of a mix of tabs and spaces (which python 3 will break on)

For some reason this change breaks unit tests, but only slightly? The assignments stay the same, but the cluster MRFs are ever so slightly different: 5.9496 vs 5.9497 on the second diagonal entry (which shouldn't matter anyway?).

@RasmusFonseca
Copy link
Contributor

Does this break py27 compatibility? I think I kept

try:
  import builtins as bt
except ImportError:
  import __builtin__ as bt

and then it still worked in 2.7

@RasmusFonseca
Copy link
Contributor

That's all assuming theres a good reason to not just change bt.len to len which is the only use for the builtins import I think.

@scoutsaachi
Copy link
Collaborator Author

@davidhallac Unless you overrode bt.len somewhere and I didn't catch it, I don't think we need the builtins import

@davidhallac
Copy link
Owner

@scoutsaachi Nope, I didn't override bt.len. I think we should be able to use the default one and remove builtin from the distribution

@davidhallac davidhallac merged commit fec802f into davidhallac:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants