Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report coverage #863

Merged
merged 8 commits into from
Jul 30, 2018
Merged

Report coverage #863

merged 8 commits into from
Jul 30, 2018

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Jul 29, 2018

TODO:

Includes/rebased on #864 for now.

@codecov-io
Copy link

codecov-io commented Jul 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b33392c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #863   +/-   ##
=========================================
  Coverage          ?   22.99%           
=========================================
  Files             ?        2           
  Lines             ?      574           
  Branches          ?      112           
=========================================
  Hits              ?      132           
  Misses            ?      433           
  Partials          ?        9
Flag Coverage Δ
#py27 21.6% <ø> (?)
#py36 20.9% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33392c...04f6222. Read the comment docs.

@blueyed blueyed force-pushed the cov branch 4 times, most recently from 7bffa8d to e3d37d1 Compare July 29, 2018 20:24
@blueyed
Copy link
Collaborator Author

blueyed commented Jul 29, 2018

For some reason py2 is not working: https://travis-ci.org/davidhalter/jedi-vim/jobs/409612945

:checkhealth reports it to be ok, but during tests has('python') appears to be false.

@blueyed
Copy link
Collaborator Author

blueyed commented Jul 29, 2018

Found it:

provider/pythonx: Could not load Python 2:^@ /home/travis/virtualenv/python2.7.14/bin/python2 is Python Coverage.py warning: --include is ignored because --source is set (include-ignored)^@ 2.7 and cannot provide Python 2.

A Coverage.py warning apparently causes pytest to not detect py2 correctly.. :/

@blueyed
Copy link
Collaborator Author

blueyed commented Jul 29, 2018

20.9% coverage.. \o/

Needs some cleanup, but should be good then already (let's get the branches/PRs it depends on though in anyway).

Next step would be covimerage to track coverage for the Vimscript part.

@blueyed
Copy link
Collaborator Author

blueyed commented Jul 29, 2018

Acutally > 25% (flags were broken).

Something looks a bit odd, e.g. https://codecov.io/gh/davidhalter/jedi-vim/src/ce0d16a4dfafdcd92bae67475dcd0d2b5b6fabae/pythonx/jedi_vim.py#L166 (is there an exception/error happening?).

@blueyed
Copy link
Collaborator Author

blueyed commented Jul 30, 2018

Should be good, but I want to cleanup/review it myself once more.

@blueyed
Copy link
Collaborator Author

blueyed commented Jul 30, 2018

I like it! ;)

Should be squash-merged (I can do it).

@davidhalter
Copy link
Owner

I'll just put you in charge for this. :) I like that we have coverage and don't really care how it's exactly done!

@blueyed blueyed merged commit 8850289 into davidhalter:master Jul 30, 2018
@blueyed blueyed deleted the cov branch July 30, 2018 20:45
@blueyed
Copy link
Collaborator Author

blueyed commented Jul 30, 2018

Yeah! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants