Use system default buffering on Python 2 #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
- Coverage 92.78% 92.72% -0.06%
==========================================
Files 57 57
Lines 6902 6902
==========================================
- Hits 6404 6400 -4
- Misses 498 502 +4
Continue to review full report at Codecov.
|
|
Great, thanks! Good catch. |
zzbot
added a commit
to ycm-core/ycmd
that referenced
this pull request
Jun 23, 2018
[READY] Include Jedi performance improvements This includes PRs davidhalter/jedi#1149, davidhalter/jedi#1150, davidhalter/jedi#1151, and davidhalter/jedi#1152 which significantly improve performance especially on Windows and Python 2. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1056) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, streams are unbuffered on Python 2 (
bufsize = 0) while system default buffering is used on Python 3 (bufsize = -1). Using system default buffering as well on Python 2 improves performance.Here are some measurements obtained with this script when completing the
os,numpy, andcv2(opencv-python) modules on Python 2 and Ubuntu 18.04 64-bit:This change is