Use cPickle on Python 2 if available #1151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the cPickle module if available since it is a C implementation of pickle that is way faster.
Here are the difference between pickle and cPickle measured with this script when completing the
os
,numpy
, andcv2
(opencv-python) modules on Ubuntu 18.04 64-bit:We can see a significant improvement for all combinations of Python except when the interpreter running Jedi and the environment are both Python 3 (which is expected since there is no cPickle on Python 3).
This change is