Allow some unparenthesized syntactic structures in f-string expression part #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
reviewed
Nov 19, 2020
| @@ -154,5 +154,5 @@ strings: (STRING | fstring)+ | |||
| fstring: FSTRING_START fstring_content* FSTRING_END | |||
| fstring_content: FSTRING_STRING | fstring_expr | |||
| fstring_conversion: '!' NAME | |||
| fstring_expr: '{' testlist_comp [ fstring_conversion ] [ fstring_format_spec ] '}' | |||
There was a problem hiding this comment.
Huh, I wonder why this is different than 3.7+
isidentical
approved these changes
Nov 19, 2020
|
Thanks @gousaiyang |
thatch
added a commit
to thatch/LibCST
that referenced
this pull request
Nov 21, 2020
Thanks to davidhalter/parso#159 for catching that yield (as an expression, I suppose) is allowed on 3.7+
thatch
added a commit
to thatch/LibCST
that referenced
this pull request
Nov 21, 2020
Thanks to davidhalter/parso#159 for catching that yield (as an expression, I suppose) is allowed on 3.7+
thatch
added a commit
to thatch/LibCST
that referenced
this pull request
Nov 24, 2020
Thanks to davidhalter/parso#159 for catching that yield (as an expression, I suppose) is allowed on 3.6.
jimmylai
pushed a commit
to Instagram/LibCST
that referenced
this pull request
Nov 30, 2020
* Support named unicode characters in f-strings This is the same as my pull request davidhalter/parso#160 * A small bugfix to what is allowed in f-string expressions Thanks to davidhalter/parso#159 for catching that yield (as an expression, I suppose) is allowed on 3.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157, #158