-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit hidden 2 #107
Inherit hidden 2 #107
Conversation
I tried a bit of performance testing on this. I did 20 page loads in my Moodle sandbox of a course with 50 sections, with and without the change, with performance info turned on. With the change averaged only about 1% slower. I don't know how accurate this is, but it seems promising. |
Thanks @james-cnz ... I am going to test it in order to integrate in the new release. |
Hi @james-cnz ... I did merge your code with some little changes in the next branch: Please, help me to test before upgrade the new official version. Saludos |
I think there is an error. (I don't think it's my change though, I think it's related to #97.) |
Not really because the first tab always is a parent tab, the level parameter is omitted in this case with the condition: I was testing both cases and not found error. Please, test it in a course. Gracias Saludos |
I did test, but I guess I didn't explain very well. |
ah... ok... you have all the reason. The step by step example is useful to test. Thanks for it. I fixed it now as you suggest. Saludos |
This is another attempt to close #83. It's smaller than #98, and it seems to work, including for activity navigation, which was a problem before. It probably needs more testing though. I'm also not sure if performance will be OK on large courses.