Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "$regex" inside "$not" queries on Mongo 4 #83

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

arieltorti
Copy link
Contributor

Fix for #81

Mongo 4.* now allows "$regex" inside "$not" queries:

 {"$not": {"$regex": "(?i)Hello World"}}

This patch modifies the behavior so that it's allowed in Mongo 4.* but not in Mongo 3.*

@davidlatwe
Copy link
Owner

Hey @arieltorti , The code looks really good and thanks for the fast contribution. 👍🏼

I have nothing to add, let me know if you are happy to merge and I'll merge it.

@arieltorti
Copy link
Contributor Author

Awesome, let's merge it then. Could we do a release including these changes?

@davidlatwe
Copy link
Owner

Yeah, will make a 2.5.1 release later once merged :)

@davidlatwe davidlatwe merged commit 4653538 into davidlatwe:master Jul 21, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants