Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter init #165

Merged
merged 5 commits into from
Sep 12, 2018
Merged

Filter init #165

merged 5 commits into from
Sep 12, 2018

Conversation

BridgeAR
Copy link
Contributor

@BridgeAR BridgeAR commented Sep 11, 2018

Fixes: #144

Tested in Node.js 10 and 8

Before:

image

After:

image

The detection will now rely on the `anonymous` function that is used
by node to wrap modules. The very first of such entries is detected
and all other entries must be init frames. This is reliable in a way
that further changes to Node.js internals in the init phase will not
have any impact on the detection.
Copy link
Owner

@davidmarkclements davidmarkclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit be8e703 into davidmarkclements:master Sep 12, 2018
mcollina added a commit that referenced this pull request Sep 18, 2018
This reverts commit be8e703, reversing
changes made to 2bbc814.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants