[WIP] Response to feedback #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds UI for creating, deleting, and viewing sharable keys. * Fixes linting
…on-refactor # Conflicts: # src/charactersheet/viewmodels/character/saving_throws/index.js
Validation refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
[/] Adds healing to the death saving throw card
Issues Fixed
[x] Add back in profile name somewhere. (will be added to header)
[x] Ensure pcard notifications are still triggered. (delayed until code revision complete)
[/] limit length of data in table rows
[/] white meditation/tent icon on tracked table
[/] Restore ranges for field restrictions (Use model validation requirements)
[/] Add "Always Prepared" icon to spell edit form for clarity
[/] AC don/doff from table needs to notify AC
[/] delay resize on magic items for has/does not have charges
[/] weight/cost better description on sorts
[/] refactor base table to unsortable data
[/] fix tab number hotkeys
[/] Fix resize on add skill
Changes Proposed (if any)
Screen Shot of Proposed Changes (if UI related)