-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finishing Level 3 on a free account results in wrong graph display #719
Comments
user.currentLevel is capped at maxLevelGrantedBySubscription which causes davidsansome#719 due to an implementation oversight
@HealsCodes Nice find! I've proposed #722 which I believe would display just the level 3 graph (the level 4 graph being useless as it is locked). |
user.currentLevel is capped at maxLevelGrantedBySubscription which causes #719 due to an implementation oversight
@davidsansome FYI I was wrong about my assumption because getAssignmentsAtUsersCurrentLevel apparently uses user.level instead of user.currentLevel, so it will now only display the level 4 graph, and not the more useful level 3 graph. tsurukame/ios/LocalCachingClient.swift Lines 533 to 538 in 4369ee6
You can delete line 237 from the main view controller if you want or change the behavior of this function, but I'm not going to test this because this might affect people on monthly subscriptions whose subscriptions have lapsed (e.g. level 23 and then the max level granted becomes 3 again) |
I just hit the end of level 3 on my free account but still have some vocabulary and even one kanji left to learn.
WaniKani shows me as 'level 4' but still lets me finish off level 3. Tsurukame on the other hand shows me as 'level 4' in the top bar with a 'current level 2' graph and empty 'level 3' graph below.
See the screenshot for better understanding:
The text was updated successfully, but these errors were encountered: