Minor fixes: fix relative paths in .nsv + some cosmetics #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_b_size also assert that they are equal
…ectory. Previously, the current working directory was used. This could lead to less predictable behaviour.
…instead of sending a message to mailing list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When reading .nsv files, now we treat relative paths as relative to the .nsv directory.
Previously, the current working directory was used. This could lead to less predictable behaviour.
Note that usually we use absolute paths, but relative paths are required for our
test/data/.Added more strict checks for input file extensions in sdp2input (
.nsv,.json,.m) and pvm2sdp (.nsv,.xml).Remove obsolete CUDA and mpmat tests
Some cosmetic fixes.