Integration tests improvements #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…match On Yale cluster, we discovered that MPI process can fail with exit code 1, but srun then exits with code 137. The tests should pass in this case, we ensure correctness by checking required_error_msg. Also print stderr to console for each failed test
call it only once for each top-level diff function
We'll need it in future for testing binary sdp format davidsd#79
… and calls diff(a,b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements:
stderrto console if process fails.El::BigFloat, compare them up to a specified precision (necessary for end-to-end tests).DIFF(a,b)macro printing argument names