Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Dockerfile #130

Merged
merged 2 commits into from
Sep 26, 2023
Merged

New Dockerfile #130

merged 2 commits into from
Sep 26, 2023

Conversation

vasdommes
Copy link
Collaborator

@vasdommes vasdommes commented Sep 26, 2023

Added Dockerfile to root.

Usage:

docker build . --tag sdpb
docker run sdpb mpirun -n 1 sdpb --help

Major differences from 2.5.1 (see docs/site_installs/sdpb_dev_Dockerfile):

  • Self-contained, no need to download images by hand, rename files etc.
  • SDPB only, no blocks_3d etc. (TODO create separate bootstrap_bundle?).
  • Multi-stage build to reduce image size.
  • Based on (recommended by Docker) Alpine Linux instead of Debian => image size 143MB instead of 396MB.
  • separate 'test' target allowing to run sdpb tests as follows (will be used e.g. for CI):
docker build . --tag sdpb-test --target test
docker run sdpb-test ./test/run_all_tests.sh mpirun --oversubscribe

/bin/bash is absent in some systems (e.g. Alpine Linux used in Docker), /bin/sh is more portable
Major differences from 2.5.1 (docs/site_installs/sdpb_dev_Dockerfile)
- Self-contained, no need to download images by hand, rename files etc.
- SDPB only, no blocks_3d etc. (TODO create separate bootstrap_bundle)
- Multi-stage build
- Based on Alpine Linux instead of Debian => image size 143MB instead of 396MB
- separate 'test' target allowing to run sdpb tests (will be used for CircleCI):

docker build . -t sdpb-test --target test
docker run sdpb-test ./test/run_all_tests.sh mpirun --oversubscribe
@vasdommes
Copy link
Collaborator Author

vasdommes commented Sep 26, 2023

P.S. I'm going to update documentation and remove old dockerfiles after preparing separate Docker images for blocks_3d and scalar_blocks.

@davidsd davidsd merged commit 8d51b5d into davidsd:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants