Improve debug mode output: print MemUsed and MemTotal for each node, disable proc/self/statm #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mTotal at start, don't print proc/self/statm Printing proc/self/statm for each rank is too verbose, and the results are hard to read. In practice, I found that I need only MemUsed (for each node) to track progress and RAM usage. proc/self/statm can be needed in very special cases - for such cases one can always create a separate branch and enable it manually.
… mode). Previously, we got tons of lines like 0 sdpb.solve.run.iter_1.computePrimalResidues cannot parse /proc/meminfo
Example: 0 sdpb.solve.run.iter_1.step.initializeSchurComplementSolver.Cholesky_Q --- MemUsed: 5.69753 GB 0 sdpb.solve.run.iter_1.step.frobenius_product_symmetric --- MemUsed: 5.69753 GB 0 sdpb.solve.run.iter_1.step.computeSearchDirection(betaPredictor) --- MemUsed: 5.69753 GB 0 sdpb.solve.run.iter_1.step.computeSearchDirection(betaCorrector) --- MemUsed: 5.69753 GB
…::list named_timers instead
Thus we don't need to call print_max_mem_used() manually each time Fixes #162 Print peak RAM usage for each node (debug mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output from
Timerswhendebug = true:MemUsed, GBfor the first rank of each node at each timer start, see Print MemUsed for each node (debug mode) #158.---between timer name andMemUsedfor better readabilityMemTotal, GBwhen adding a first timer (it is constant, so we need to print in only once).proc/self/statm. Previously, we printed each for each timer for each rank. As a result, SDPB output became too verbose and hard to read. I found that I never usedstatmin practice -MemUsedper node is enough for tracking progress and RAM usage.