Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for 2.7.0 + fix compilation on Imperial HPC #200

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

vasdommes
Copy link
Collaborator

  • Added 2.7.0 to Changelog.md
  • Replaced 2.6.1 -> 2.7.0 when applicable
  • Fixed compilation error on Imperial HPC (GCC 11.2.0):
../test/src/unit_tests/cases/json.test.cxx:291:1: error: redefinition of ‘const char _ZTSZN18Json_Vector_ParserI17Json_Float_ParserIN2El8BigFloatEEEC4EbRKSt8functionIFvOSt6vectorIS2_SaIS2_EEEERKS5_IFvvEEEd_UlvE_ []’
  291 | }
      | ^
../test/src/unit_tests/cases/json.test.cxx:291:1: note: ‘const char _ZTSZN18Json_Vector_ParserI17Json_Float_ParserIN2El8BigFloatEEEC4EbRKSt8functionIFvOSt6vectorIS2_SaIS2_EEEERKS5_IFvvEEEd_UlvE_ [123]’ previously defined 

It is fixed by replacing Json_Float_Vector_Parser<El::BigFloat> parser(skip, on_parsed); with Json_Float_Vector_Parser<El::BigFloat> parser(skip, on_parsed, []{}); in json.test.cxx, i.e. specify the (default) third parameter explicitly.

I don't know why the error appeared only in this file (we have similar Json_Float_Vector_Parser constructors in other places) and only on Imperial HPC. Other clusters (BU, Caltech, Expanse, Harvard) us another GCC versions, from 9.2.0 to 12.2.0.

For some reason, I got the following compilation error:

../test/src/unit_tests/cases/json.test.cxx:291:1: error: redefinition of ‘const char _ZTSZN18Json_Vector_ParserI17Json_Float_ParserIN2El8BigFloatEEEC4EbRKSt8functionIFvOSt6vectorIS2_SaIS2_EEEERKS5_IFvvEEEd_UlvE_ []’
  291 | }
      | ^
../test/src/unit_tests/cases/json.test.cxx:291:1: note: ‘const char _ZTSZN18Json_Vector_ParserI17Json_Float_ParserIN2El8BigFloatEEEC4EbRKSt8functionIFvOSt6vectorIS2_SaIS2_EEEERKS5_IFvvEEEd_UlvE_ [123]’ previously defined here
@vasdommes vasdommes added this to the 2.7.0 milestone Feb 21, 2024
@vasdommes vasdommes merged commit a837094 into master Feb 21, 2024
2 checks passed
@vasdommes vasdommes deleted the release-2.7.0 branch February 21, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant