Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BOOST_WINDOWS_API support to parse.cpp #8

Merged
merged 2 commits into from Oct 21, 2015
Merged

Added BOOST_WINDOWS_API support to parse.cpp #8

merged 2 commits into from Oct 21, 2015

Commits on Oct 20, 2015

  1. Added BOOST_WINDOWS_API support to parse.cpp 

    path.c_str() returns value_type*, which is a wchar_t* if BOOST_WINDOWS_API is defined. Tinyxml uses fopen to open files, which does not take wchar_t argument. This fix leaves tinyxml invariant, but there can be an error if a file with non-ascii characters is being opened. Windows workaround is wfopen, but this function is not available on Cygwin, which is the environment that is most likely to be used on Windows to build sdpb. Cygwin follows posix, so that's why wfopen is not available. However, boost does not believe that cygwin is posix and defines BOOST_WINDOWS_API.
    @pkravchuk
    pkravchuk committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    352578b View commit details
    Browse the repository at this point in the history

  2. cosmetic changes

    @pkravchuk
    pkravchuk committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    41c1462 View commit details
    Browse the repository at this point in the history