Added BOOST_WINDOWS_API support to parse.cpp #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path.c_str() returns value_type*, which is a wchar_t* if BOOST_WINDOWS_API is defined. Tinyxml uses fopen to open files, which does not take wchar_t argument. This fix leaves tinyxml invariant, but there can be an error if a file with non-ascii characters is being opened. Windows workaround is wfopen, but this function is not available on Cygwin, which is the environment that is most likely to be used on Windows to build sdpb. Cygwin follows posix, so that's why wfopen is not available. However, boost does not believe that cygwin is posix and defines BOOST_WINDOWS_API.
davidsd
added a commit
that referenced
this pull request
Oct 21, 2015
Added BOOST_WINDOWS_API support to parse.cpp
|
That's a pretty painless change. Thanks for figuring it out! |
|
The windows version of the call would perhaps work on all systems, but I can't test this. It's perhaps the safest to just leave it as it is. |
|
I just tested the windows call on Linux, and it seems to work fine. So I'll just switch to that and remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.c_str() returns value_type*, which is a wchar_t* if BOOST_WINDOWS_API is defined. Tinyxml uses fopen to open files, which does not take wchar_t argument. This fix leaves tinyxml invariant, but there can be an error if a file with non-ascii characters is being opened. As far as ascii characters are concerned, everything should be ok. I don't know a good solution to this problem, here's why. Windows standard workaround is wfopen, but this function is not available on Cygwin, which is the environment that is most likely to be used on Windows to build sdpb. The reason for no wfopen is that Cygwin follows posix. However, boost does not believe that cygwin is posix and defines BOOST_WINDOWS_API. Perhaps I missed something, but that seems to be the situation.