Fixed "All Selected" problem on non-multiselect with one option #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s some situation when there are only one option and that displays “All selected” which is only correct if the select tag is “multiple”. In using this plugin for “single” dropdowns as well, there are situations when there’s only one option and it shouldn’t show “All selected”. This fixes that
|
I had the exactly same problem and solved it in the exact same way. You made the pull request one week before me well done ! |
|
Looks good, thanks! |
davidstutz
added a commit
that referenced
this pull request
May 25, 2015
Fixed "All Selected" problem on non-multiselect with one option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s some situation when there are only one option and that displays
“All selected” which is only correct if the select tag is “multiple”.
In using this plugin for “single” dropdowns as well, there are
situations when there’s only one option and it shouldn’t show “All
selected”. This fixes that.
The problem:
The fix:
