Skip to content

Commit

Permalink
ui: Fix loading spinner glitch.
Browse files Browse the repository at this point in the history
On calling `loading.make_indicator` for the second
time or more no spinner is being displayed.

This bug can be viewed on visiting a `near: 1` narrow
and the spinner for the newer messages is displayed
only once (i.e. the first time it is rendered), while
the logo is displayed every time.

This happens because `loading.destroy_indicator` sets
the css of that container to display: "none". This can
be removed as we are emptying the container just above.

Introduced in 953d475.
  • Loading branch information
ryanreh99 authored and timabbott committed Jul 20, 2020
1 parent 619f11a commit 1696c9a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion static/js/loading.js
Expand Up @@ -59,7 +59,7 @@ exports.destroy_indicator = function (container) {
}
container.removeData("spinner_obj");
container.empty();
container.css({width: 0, height: 0, display: "none"});
container.css({width: 0, height: 0});
};

window.loading = exports;

0 comments on commit 1696c9a

Please sign in to comment.