Skip to content

Commit

Permalink
Add support for Python3.6 lib search with Cmake (#527)
Browse files Browse the repository at this point in the history 
* Add support for Python3.6 lib search with Cmake

A recent commit added support for python3.5 lib search with Cmake. This PR extends that to python 3.6.

Relevant old commit: 17a2c75

* Turn python versions into a list
  • Loading branch information
@davisking
Joost van Amersfoort authored and davisking committed Apr 7, 2017
1 parent 99ee80d commit 664ef39
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dlib/cmake_utils/add_python_module
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ if (PYTHON3)
if (NOT Boost_FOUND)
FIND_PACKAGE(Boost 1.41.0 COMPONENTS python)
endif()
set(Python_ADDITIONAL_VERSIONS 3.5)
set(Python_ADDITIONAL_VERSIONS 3.5 3.6)
FIND_PACKAGE(PythonLibs 3.4 REQUIRED)
else()
FIND_PACKAGE(Boost 1.41.0 COMPONENTS python)
Expand Down

3 comments on commit 664ef39

@teanoice
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed python 3.6 and I download this file but I still cant fix the problem python setup.py install and then the problem of cant not find boost still there, what should I do ? Thanks

@davisking
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://dlib.net/faq.html#Whywon'tthePythonbindingscompilework

@teanoice
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But when I using the command cmake --build . --config Release ,it stock at dnn_face_recognition_ex.vcxproj, sorry but how to fix this? and the solution in the address you gave still not solve the problem i met, can you told me the command to install boost thanks a lot very appreciate

Please sign in to comment.