Add support for Python3.6 lib search with Cmake #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit added support for python3.5 lib search with Cmake. This PR extends that to python 3.6. Relevant old commit: 17a2c75
|
I'm pretty sure that overwrites 3.5. It probably needs to be a list. |
|
Right, I didn't realize that and only tested on 3.6. New commit should solve it. |
|
Cool, thanks for the PR :) |
E452003
pushed a commit
to E452003/dlib
that referenced
this pull request
Feb 12, 2018
* Add support for Python3.6 lib search with Cmake A recent commit added support for python3.5 lib search with Cmake. This PR extends that to python 3.6. Relevant old commit: davisking@17a2c75 * Turn python versions into a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit added support for python3.5 lib search with Cmake. This PR extends that to python 3.6.
Relevant old commit: 17a2c75