-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLIB_ISO_CPP_ONLY is broken #579
Comments
It's not broken. This is just what happens when you disable that part of the code. I don't know what you would expect to happen. Although, honestly, I'm tempted to remove the DLIB_ISO_CPP_ONLY switch since I suspect mightily that no one really uses it. |
Wouldn't you expect it to work as outlined in the "documentation"?
|
Yes. Some things depend on that stuff. Like part of the shape prediction tooling.
|
Though the predictor itself doesn't depend on threads, and the trainer's declaration could be moved to a separate header (not sure why the thread part has to be OS dependent in the first place, since DLib requires a C++11 compiler why can't it use |
Because a lot of dlib was written before there was C++11 support in compilers. Also, yes, many things could be split up. You can almost always split source files into smaller parts, we could make it so there are 10,000 source files instead of about 1000. But I'm not doing that. Do you have a use case that is somehow impacted by what you are posting about? |
The use case is pretty simple: all I use from DLib is the shape predictor, and since it's implemented solely in headers I'd like to benefit from a header-only part of DLib, not having to build it for various platforms. |
Sure. If you want to move the |
Sorry, had no idea how to link PR to an issue... so here it is #599 |
No worries. Thanks for the PR :) |
Here's what I get when trying to use
dlib::shape_predictor
withDLIB_ISO_CPP_ONLY
defined:Please note, (at least as of 19.1) commenting out
dlib::shape_predictor_trainer
indlib/image_processing/shape_predictor.h
fixes the issue.The text was updated successfully, but these errors were encountered: