Clarified requirements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu has Ruby 1.8 installed by default, so this should save the time of some Ubuntu users.
|
Also, what is Readline? I don't have it installed as a gem, but the example ran anyways. As a side note, this is my first pull request so let me know if I should include more detail in the description in the future. |
|
It's fine and thanks :) Well, with Readline there's kinda interesting, it should be built-in Ruby, but for some cases it's not, or used not to be. Maybe in previous Ruby versions or I guess for windows. So there's rb-readline gem for that case. And usually it shouldn't be required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu has Ruby 1.8 installed by default, so this should save the time of some Ubuntu users.