Fixing for sprockets 3 in production

[naps62]

Fixes #18

A recent sprockets update changed some internals, which prevented this gem from working in production

This sprockets-rails issue describes the actual error that caused this: rails/sprockets-rails#237
In production, Rails.application.assets is only set if config.assets.compile is enabled (and it's not enabled by default in production)

This fix worked for my. I'm not sure if it works as a global solution, but I supose it should

One thing still remains in the codebase which I did not fix: the whole problematic code is surrounded by a begin/rescue, which completely silences any errors within it, which made it harder to spot the problem in the first place, and will make it harder to see if it's working again

I'm not sure why it was originally put there, but I didn't remove it (although we probably should, it's a very big smell)

[naps62]

This was previously not working. because of the empty begin/rescue in there it took me a while to notice and fix the error

But as of today it's working again, and being used by my company in production.

@davydotcom can you take a look?

[davydotcom]

Awesome thanks! I'll get this released

[heidiv]

hello, just wondering if this has been updated on rubygems? Thanks!

[naps62]

@heidiv seems not. The last update on rubygems was in April.
Would be nice do so, though

[heidiv]

@naps62 April 2014?! I tried to reference this repo in my Gemfile but got permission denied. Suggestions for getting the latest? Would prefer not to copy the code into my proj but perhaps that's what's needed.

[naps62]

Uh! I didn't even notice it was 2014...

How are you referencing the repo in your Gemfile? This should work:

gem "retina_tag", github: "davydotcom/retina_tag", ref: "2da1897"

The ref argument is optional, but it's a good practice to make sure you don't end up getting surprise updates

[davydotcom]

released 1.4.1 with the fixes, thanks!

[heidiv]

Thanks @davydotcom !!