Merge pull request fsprojects#3091 from dawedawe/fix_3088

Fix exn in (|UppercaseExpr|LowercaseExpr|)

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 6.3.6 - 2024-06-01
+
+### Fixed
+* Fix case determination issue with ExprAppSingleParenArgNode. [#3088](https://github.com/fsprojects/fantomas/issues/3088)
+
 ## 6.3.5 - 2024-05-30
 
 ### Fixed

src/Fantomas.Core.Tests/DynamicOperatorTests.fs

@@ -76,3 +76,37 @@ let ``preserve back ticks from checked keyword, 937`` () =
         """
 let toggle = unbox<bool> (e.target?``checked``)
 """
+
+[<Test>]
+let ``case determination issue with ExprAppSingleParenArgNode, 3088`` () =
+    formatSourceString
+        """
+let doc = x?a("")?b(t)?b(t)
+"""
+        config
+    |> prepend newline
+    |> should
+        equal
+        """
+let doc = x?a ("")?b (t)?b (t)
+"""
+
+[<Test>]
+let ``case determination issue with ExprAppSingleParenArgNode uppercase with config lower, 3088`` () =
+    // We want to disobey SpaceBefore(Upper|Lower)caseInvocation inside of the ? chain because mixing it up can generate invalid code like x?a("arg")?B ("barg")?c("carg")
+    // The space config that is used (Upper or Lower) depends on the case of the dynamic object, here x
+    formatSourceString
+        """
+let doc1 = x?a("arg")?B("barg")?c("carg")
+let doc2 = X?a("arg")?B("barg")?c("carg")
+"""
+        { config with
+            SpaceBeforeLowercaseInvocation = false
+            SpaceBeforeUppercaseInvocation = true }
+    |> prepend newline
+    |> should
+        equal
+        """
+let doc1 = x?a("arg")?B("barg")?c("carg")
+let doc2 = X?a ("arg")?B ("barg")?c ("carg")
+"""

src/Fantomas.Core/CodePrinter.fs

@@ -57,6 +57,7 @@ let rec (|UppercaseExpr|LowercaseExpr|) (expr: Expr) =
     | Expr.DotIndexedGet node -> (|UppercaseExpr|LowercaseExpr|) node.ObjectExpr
     | Expr.TypeApp node -> (|UppercaseExpr|LowercaseExpr|) node.Identifier
     | Expr.Dynamic node -> (|UppercaseExpr|LowercaseExpr|) node.FuncExpr
+    | Expr.AppSingleParenArg node -> (|UppercaseExpr|LowercaseExpr|) node.FunctionExpr
     | _ -> failwithf "cannot determine if Expr %A is uppercase or lowercase" expr
 
 let (|ParenExpr|_|) (e: Expr) =