Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Copy Image to clipboard #49

Closed
abhimanyu003 opened this issue Sep 27, 2017 · 6 comments
Closed

Feature request: Copy Image to clipboard #49

abhimanyu003 opened this issue Sep 27, 2017 · 6 comments
Labels
enhancement

Comments

@abhimanyu003
Copy link

abhimanyu003 commented Sep 27, 2017 •
edited

It will be really great if there is copy to clipboard option.
Quite helpful when you have to share the image to slack - discord or any other chatting application which supports direct upload.
@briandennis
Copy link
Collaborator

yesssss! @jakedex do you think this should be a separate button or can we integrate this to the existing UI somehow?

@jakedex
Copy link
Collaborator

jakedex commented Sep 30, 2017

We could change the 'Save Image' -> 'Copy Image' when the user holds shift?

@jakedex jakedex mentioned this issue Oct 2, 2017
Closed
@jakedex jakedex assigned jakedex and unassigned jakedex Oct 5, 2017
@abhimanyu003
Copy link
Author

I don't think updating 'Save Image' -> 'Copy Image', when the user holds shift, is a good idea.

The other thing we can do is open image in base64 output in the new tab?
After which user only have to right click and click copy image in the browser.

@jakedex jakedex removed their assignment Dec 31, 2017
@yeskunall yeskunall mentioned this issue Jan 25, 2018
Closed
@rehatkathuria
Copy link

I think this could be a nice solution? #179

@mfix22 mfix22 mentioned this issue Feb 2, 2018
Closed
@martinfrancois
Copy link
Contributor

Maybe we could turn the current buttons into (font awesome) icons? We could then use a Twitter icon for the tweet button, a clipboard icon for saving to clipboard and a save icon for saving? Would be much more compact that way and would not look crowded.

@VinSpee
Copy link
Contributor

VinSpee commented Jul 25, 2018

Copying image data to the clipboard is still not supported in browsers. Maybe the best solution would be what @abhimanyu003 suggested. Any opposition?

VinSpee pushed a commit to VinSpee/carbon that referenced this issue Jul 25, 2018
feat(save): add "copy" button
e8e8da6 
add a button to the save menu called "copy", which opens the raw image data in the window so users
can directly copy it for easy pasting into a variety of apps

carbon-app#49
@VinSpee VinSpee mentioned this issue Jul 25, 2018
Merged
mfix22 pushed a commit that referenced this issue Aug 3, 2018
@VinSpee
feat(save): add "copy" button (#441)
a7159f8 
* feat(save): add "copy" button

add a button to the save menu called "copy", which opens the raw image data in the window so users
can directly copy it for easy pasting into a variety of apps

#49

* feat(save): open in a new window

update the action to open in a new window and rename it to "open"

* simplify open logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@abhimanyu003 @VinSpee @rehatkathuria @mfix22 @briandennis @jakedex @martinfrancois