Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Update eslint-plugin-node to the latest version 馃殌 #185

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented Jun 2, 2017

Version 5.0.0 of eslint-plugin-node just got published.

Dependency eslint-plugin-node
Current Version 4.2.2
Type devDependency

The version 5.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of eslint-plugin-node.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes v5.0.0

Notable changes are 2:

  1. Node.js 8 support were added.
  2. The check of extraneous packages were separated from no-unpublish-import rule and no-unpublish-require rule.

Breaking changes

  • 3387336 updated no-unsupported-features rule for Node.js 8.
    • Node.js 8 newly supports trailing commas in functions.
    • This rule went to use 4.0.0 if you don't specify the node version. It has been 0.10.0 before.
    • This rule went to warn SharedArrayBuffer and Atomics. Currently any versions of Node.js don't support those variables.
  • 0e487f9 updated no-deprecated-api rule for Node.js 8.
    • Node.js 8 deprecated vm.runInDebugContext().
    • Additionally, Node.js 8 made the official page about deprecated APIs. I realized this rule had been lacking the check of some deprecated APIs. I added those.
  • d4e6bc4 removed the check about extraneous packages from no-unpublish-import rule and no-unpublish-require rule.

New rules

  • a75c638 added 2 new rules, no-extraneous-import and no-extraneous-require. Those rules report require() expressions or import declarations if those import extraneous packages.
    • Those behavior were extracted from no-unpublished-require and no-unpublished-import.

Bug fixes

  • deb4f55 fixed a bug of no-unsupported-features about semver comparison. (#78)
Commits

The new version differs by 14 commits.

  • 5634718 5.0.0
  • aea8e82 Chore: remove deprecated rule's tests
  • 118a1de Chore: add note about require("punycode/") (fixes #72)
  • cf36e6d Chore: improve auto-generation script
  • d4e6bc4 Breaking: remove extraneous check from no-unpublish-* (fixes #71)
  • a75c638 New: no-extraneous-* rules (refs #71)
  • deb4f55 Fix: no-unsupported-features goes wrong on >=7.10.0 (fixes #78)
  • 0e487f9 Breaking: update no-deprecated-api (fixes #80)
  • 3387336 Breaking: update no-unsupported-features rule (fixes #79)
  • fdd7877 Chore: add Node.js 8 to CI
  • fa95be2 Chore: add cache to exists()
  • ffc7fcb Chore: refactor with classes.
  • 8f00ebb Chore: remove object-assign from dependencies
  • 734d2e7 Chore: upgrade dependencies

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 馃尨

@codecov
Copy link

codecov bot commented Jun 2, 2017

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files           9        9           
  Lines         241      241           
=======================================
  Hits          224      224           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b71f525...c1e6493. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.62% when pulling c1e6493 on greenkeeper/eslint-plugin-node-5.0.0 into b71f525 on master.

@lusentis lusentis closed this Jun 24, 2017
@greenkeeper greenkeeper bot deleted the greenkeeper/eslint-plugin-node-5.0.0 branch June 24, 2017 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants