Skip to content

Commit

Permalink
this kind of static message should be moved to the metric's error des…
Browse files Browse the repository at this point in the history
…cription not to bloat databases needlessly
  • Loading branch information
charsbar authored and daxim committed Apr 12, 2013
1 parent 4e42880 commit fc49762
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/Module/CPANTS/Kwalitee/Files.pm
Original file line number Diff line number Diff line change
Expand Up @@ -281,13 +281,12 @@ sub kwalitee_indicators {
},
{
name=>'no_stdin_for_prompting',
error=>q{This distribution is using direct call from STDIN instead of prompt())},
error=>q{This distribution is using direct call from STDIN instead of prompt(). Make sure STDIN is not used in Makefile.PL or Build.PL. See http://www.perlfoundation.org/perl5/index.cgi?cpan_packaging},
is_extra=>1,
remedy=>q{Use the prompt() method},
code=>sub {
my $d=shift;
if ($d->{stdin_in_makefile_pl}||$d->{stdin_in_build_pl}) {
$d->{error}{no_stdin_for_prompting} = "Make sure STDIN is not used in Makefile.PL or Build.PL see http://www.perlfoundation.org/perl5/index.cgi?cpan_packaging";
return 0;
}
return 1;
Expand Down

0 comments on commit fc49762

Please sign in to comment.