Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event/epoch history explorer #244

Closed
wants to merge 7 commits into from

Conversation

heralden
Copy link
Contributor

@heralden heralden commented Jul 12, 2019

Thanks for the immensely useful dev tool!

I think we can make it even better! Something I miss from a similar tool (Redux dev tools) is an overview/history of all events/epochs, allowing you to scroll through them and jump to a specific one.

I created a MVP that fulfills the above description, but I'd like to get some feedback on it and some ideas I have to improve it, which I'll work on next week.

2019-07-12-175557_670x338_scrot

It's hidden by default and is toggled with the up/down arrow below the skip-to-last button (which I made smaller and pushed up).

Here's the stuff on my list:

  • Fix alignment and sizes of skip-to-last and toggle button
  • Save open/close state to local storage so it can be restored (not sure if this is worth doing as I imagine the history explorer would generally be used to jump between a few epochs, then close it once done)
  • Fix first event init-db not being shown as active when selected (differing id?)
  • Perhaps different font color for future events when any other than the most recent event is selected, to indicate that these haven't happened yet
  • Try to make the simple css resize handle prettier not possible in firefox, and it looks fine in chrome/webkit
  • If possible, simplify the :epochs/all-indexed-events sub (name could be improved as well?)
  • Test with long events to make sure they create ellipses

Update: I'm pretty happy with how things are now, so I'll wait for feedback for now.

@heralden heralden changed the title [WIP] Event/epoch history explorer Event/epoch history explorer Jul 19, 2019
:epochs/all-indexed-events would break down in some scenarios, so I
found (:matches-by-id epochs) which seems like the correct way to
implement this.
@superstructor
Copy link
Contributor

Thanks for this awesome contribution @uosl and apologies for taking as long as we have to merge it!

Due to conflicts recently introduced on master I pulled your feature/event-history branch locally, rebased on master and merged.

It will be released as 0.4.4 soon.

@heralden
Copy link
Contributor Author

Thanks for merging! And no worries, I know handling open source contributions can be a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants