Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control points rotation is wrong #151

Closed
ladifire opened this issue Jan 9, 2020 · 15 comments
Closed

Control points rotation is wrong #151

ladifire opened this issue Jan 9, 2020 · 15 comments
Labels
bug Something isn't working complete
Milestone

Comments

@ladifire
Copy link

ladifire commented Jan 9, 2020

Environments

  • Framework name: React
  • Framework version: 16
  • Component name: Control points
  • Component version:
  • Testable Address(optional): No

Description

Please this gif. When using rectangle shape for control points. The rotation set for them is wrong.

Please fix this in future version.
captured

@daybrush
Copy link
Owner

daybrush commented Jan 9, 2020

@ladifire

What is the component version? This problem has been solved for a long time?

스크린샷 2020-01-10 오전 1 03 56

스크린샷 2020-01-10 오전 1 06 05

@daybrush daybrush added the bug Something isn't working label Jan 9, 2020
@ladifire
Copy link
Author

This bug is in react-moveable package, please see this demo
https://codesandbox.io/s/react-moveable-demo-66w9h

@daybrush
Copy link
Owner

@ladifire

This problem will be solved by updating react-moveable.

@ladifire
Copy link
Author

Yes! thankyou!

@iprasadg
Copy link

iprasadg commented Jan 10, 2020

@daybrush In ngx-movable (version 0.9.3) also the direction cursor (cursor pointer) is not updating.

@daybrush
Copy link
Owner

@iprasadg

What does it mean that the direction cursor doesn't update? is it custom CSS? Can you give me a gif?

@iprasadg
Copy link

@daybrush Without rotate cursor styles are correct i.e showing according to direction. But, after rotate cursor style should get updated. It is showing previous style of cursor. See the following gif

cursor

@daybrush
Copy link
Owner

@iprasadg

Oh I didn't think that part. This may take a while, but I'll fix it soon.

@ladifire
Copy link
Author

This is so difficult to fix, because it's cursor, not part of component. I find out that Figma (https://www.figma.com/) generate cursor for every rotate then assign each cursor for each rotation position.

@daybrush
Copy link
Owner

@ladifire

I'm thinking about it too, but probably an svg cursor. I'm thinking of changing the angle every 10 degrees.

@daybrush
Copy link
Owner

@ladifire @ladifire
There may be browser support issues, so the default is likely to be 45 degrees.

@daybrush daybrush added this to the 0.13.4 milestone Jan 10, 2020
daybrush added a commit that referenced this issue Jan 10, 2020
@ladifire
Copy link
Author

Your last commit not working with edge={true}
captured (3)

@daybrush
Copy link
Owner

@ladifire @iprasadg

A new version has been released.

  • moveable 0.13.4
  • react-moveable 0.16.6
  • preact-moveable 0.15.5
  • ngx-moveable 0.9.4
  • svelte-moveable 0.4.4

Update to the new version. Thank you :)

@ladifire
Copy link
Author

Thanks @daybrush, it's sunday but you've worked hard!

@iprasadg
Copy link

@daybrush Updated to the new version. Thanks for resolving issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

3 participants