Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate repo entry frontend validation #550

Closed
idagelic opened this issue May 14, 2024 · 10 comments · Fixed by #729
Closed

Duplicate repo entry frontend validation #550

idagelic opened this issue May 14, 2024 · 10 comments · Fixed by #729
Labels
💎 Bounty bug Something isn't working 💰 Rewarded

Comments

@idagelic
Copy link
Member

Describe the bug
Adding the same repository twice in a multi project workspace creation flow errors only after submitting the request instead of doing some sort of frontend validation.

To Reproduce
Steps to reproduce the behavior:

  1. Run daytona create --multi-project
  2. Set https://github.com/daytonaio/daytona as the repo for both the first and second project
  3. Submit the form
  4. See the "duplicate repository entry" error

Expected behavior
The user should be let know there are duplicate repo entries before having submitted the form

Screenshots
image

image

Desktop (please complete the following information):

  • Daytona Version: v0.15.0
@idagelic idagelic added the bug Something isn't working label May 14, 2024
@Tpuljak
Copy link
Member

Tpuljak commented May 17, 2024

/bounty $20

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 17, 2024 •
edited
Loading

## 💎 $20 bounty • Daytona

### Steps to solve:
1. Start working: Comment /attempt #550 with your implementation plan
2. Submit work: Create a pull request including /claim #550 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Thank you for contributing to daytonaio/daytona!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🔴 @ezhil56x May 17, 2024, 6:52:57 PM WIP
🟢 @Rutik7066 Jun 15, 2024, 7:44:59 AM WIP
🟢 @abhishek818 Jul 4, 2024, 5:46:02 PM #729

@ezhil56x
Copy link
Contributor

@Tpuljak --multi-project doesn't seem to work

Click here to expand
2024-05-17.18-24-14.mp4

@Tpuljak Tpuljak mentioned this issue May 17, 2024
Closed
@Tpuljak
Copy link
Member

Tpuljak commented May 17, 2024 •
edited
Loading

@ezhil56x you're right. I opened #577 from your comment.

Nice catch!

@ezhil56x
Copy link
Contributor

ezhil56x commented May 17, 2024 •
edited by algora-pbc bot
Loading

/attempt #550

Algora profile Completed bounties Tech Active attempts Options
@ezhil56x    5 daytonaio bounties
+ 23 bounties from 10 projects
JavaScript, TypeScript,
Java & more
Cancel attempt

@ezhil56x ezhil56x mentioned this issue May 17, 2024
Closed
2 tasks
@Rutik7066
Copy link
Contributor

Rutik7066 commented Jun 15, 2024 •
edited by algora-pbc bot
Loading

/attempt #550

Algora profile Completed bounties Tech Active attempts Options
@Rutik7066 9 bounties from 6 projects
Go, Rust,
MDX & more
Cancel attempt

@daytonaBot
Copy link
Collaborator

This Issue has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thanks for the feedback.

@abhishek818
Copy link
Contributor

abhishek818 commented Jul 4, 2024 •
edited by algora-pbc bot
Loading

/attempt #550

Algora profile Completed bounties Tech Active attempts Options
@abhishek818    2 daytonaio bounties
+ 8 bounties from 5 projects
JavaScript, TypeScript
Cancel attempt

abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 4, 2024
@abhishek818
enhancement: frontend validation for duplicate repo entry in tui (day…
1285082 
…tonaio#550)

related to --multi-project command

Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
@abhishek818 abhishek818 mentioned this issue Jul 4, 2024
Merged
2 tasks
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jul 4, 2024 •
edited
Loading

💡 @abhishek818 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 4, 2024
@abhishek818
enhancement: frontend validation for duplicate repo entry in tui (day…
1ddc522 
…tonaio#550)

related to --multi-project command

Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
@daytonaBot daytonaBot removed the Stale label Jul 5, 2024
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 7, 2024
@abhishek818
major improvements for frontend validation and code refactor (daytona…
51265ca 
…io#550)

skip over duplicate repo & git provider options
disable 'enter' keypress for disabled options

Signed-off-by: abhishek kumar gupta <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 7, 2024
@abhishek818
major improvements for frontend validation and code refactor (daytona…
c3857d4 
…io#550)

skip selection/focus view over duplicate repo & git provider options
disable 'enter' keypress for disabled options

Signed-off-by: abhishek kumar gupta <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 7, 2024
@abhishek818
major improvements for frontend validation and code refactor (daytona…
8f6c096 
…io#550)

1. skip selection/focus view over duplicate repo & git provider options
   (skips git provider having all repos already selected)
2. enable validation before breaking command flow and throwing fatal error and UX flows
3. disable 'enter' keypress for disabled options

Signed-off-by: abhishek kumar gupta <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 7, 2024
@abhishek818
major improvements for frontend validation and code refactor (daytona…
1cd4e39 
…io#550)

1. skip selection/focus view over duplicate repo & git provider options
   (skips git provider having all repos already selected)
2. enable validation before breaking command flow and throwing fatal error and UX flows
3. disable 'enter' keypress for disabled options
4. handle duplicate entries over a mix of auto and manual modes (duplicate entry in manual input invoked inside auto mode)

Signed-off-by: abhishek kumar gupta <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 7, 2024
@abhishek818
major improvements for frontend validation and code refactor (daytona…
b3bfb45 
…io#550)

Related to workspace creation using multi-project command
1. skip selection/focus view over duplicate repo & git provider options
   (skips git provider having all repos already selected)
2. enable validation before breaking command flow and throwing fatal error and UX flows
3. disable 'enter' keypress for disabled options
4. handle duplicate entries over a mix of auto and manual modes (duplicate entry in manual input invoked inside auto mode)

Signed-off-by: abhishek kumar gupta <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 8, 2024
@abhishek818
add missing validation for namespaces & related view improvements (da…
cdacf6e 
…ytonaio#550)
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 8, 2024
@abhishek818
add missing validation for namespaces & related view improvements (da…
a0131f5 
…ytonaio#550)

Signed-off-by: abhishek818 <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 9, 2024
@abhishek818
fix code comment typo (daytonaio#550)
b7f3d7d 
Signed-off-by: abhishek818 <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 9, 2024
@abhishek818
rename variables (daytonaio#550)
1bc9642 
Signed-off-by: abhishek818 <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 9, 2024
@abhishek818
fix code comment typos (daytonaio#550)
c99c167 
Signed-off-by: abhishek818 <abhishekguptaatweb17@gmail.com>
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jul 9, 2024

🎉🎈 @abhishek818 has been awarded $20! 🎈🎊

idagelic pushed a commit that referenced this issue Jul 9, 2024
@abhishek818
feat: frontend validation for duplicate repo entry in tui (#550)
2c02b17 
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 17, 2024
@abhishek818
Revert "feat: frontend validation for duplicate repo entry in tui (da…
5eb395e 
…ytonaio#550)"

This reverts commit 2c02b17.
abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 20, 2024
@abhishek818
Revert "feat: frontend validation for duplicate repo entry in tui (da…
0208305 
…ytonaio#550)" (daytonaio#773)

This reverts commit 2c02b17.

Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty bug Something isn't working 💰 Rewarded
Projects
None yet
Milestone
No milestone
6 participants
@idagelic @Tpuljak @abhishek818 @Rutik7066 @ezhil56x @daytonaBot