Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/workspace): show info exit failed #188

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Twacqwq
Copy link
Contributor

@Twacqwq Twacqwq commented Mar 12, 2024

Pull Request Title

Description

This PR solved the show workspace info exit failed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Related Issue(s)

Closed #187

@Twacqwq Twacqwq changed the title fix(cmd/workspace): show info exit fix(cmd/workspace): show info exit failed Mar 12, 2024
@Tpuljak
Copy link
Member

Tpuljak commented Mar 13, 2024

As mentioned in your other PR, please include a signature in your commit and we can go ahead and approve this.

@Tpuljak
Copy link
Member

Tpuljak commented Mar 14, 2024

@Twacqwq, the PR looks great, but I'll have to ask you to change the name in your signature.

As per the DCO requirements, the signature does not necessarily need to be your full name, but something that provides enough identification for us to contact you if need be.

I suggest using your first and last name as it makes it easier and removes any ambiguity from our side.

@Twacqwq
Copy link
Contributor Author

Twacqwq commented Mar 14, 2024

@Twacqwq, the PR looks great, but I'll have to ask you to change the name in your signature.

As per the DCO requirements, the signature does not necessarily need to be your full name, but something that provides enough identification for us to contact you if need be.

I suggest using your first and last name as it makes it easier and removes any ambiguity from our side.

Got it, I will update the two recent PRs later.

@Twacqwq Twacqwq requested a review from a team as a code owner March 14, 2024 13:30
@Twacqwq Twacqwq force-pushed the workspace-info-exit branch 2 times, most recently from ad43d91 to 571b695 Compare March 14, 2024 13:45
Signed-off-by: Luo Wenhao <xiaot.qaq@gmail.com>
@Twacqwq
Copy link
Contributor Author

Twacqwq commented Mar 14, 2024

@Tpuljak Thank you for your patient advice, I have updated it.

@Tpuljak Tpuljak merged commit 9c659cf into daytonaio:main Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show workspace info exit failed
3 participants